Ticket #222 (closed Tasks: fixed)

Opened 7 years ago

Last modified 7 years ago

Improve performance of IMAP parsing code

Reported by: octo Owned by: octo
Priority: normal Milestone: 2.0
Component: LogicMail Version: 1.9.1
Keywords: Cc:
Blocked By: #224 Blocking:

Description

The core of LogicMail's IMAP implementation is a highly inefficient method called "StringParser.nestedParenStringLexer()". This method takes in an IMAP parenthesized string, and returns a tree representing its structure. While well tested and field-proven, this method is poorly written, poorly performing (in terms of memory and speed), and difficult to understand. Ever since #221 dramatically increased the performance of the network code, the slowness of this method has become more apparent.

This code needs to be completely rewritten in the cleanest way possible, as a two step operation:

  • Scan the string once, generating a vector of tokens (which are parentheses or strings)
  • Iterate across those tokens, generating the tree

Not only does this code need to pass all the unit tests for the legacy code, but new unit tests need to be written to cover international charset cases. Furthermore, the input data from the network layer may need to be changed from Strings to byte arrays to support these cases.

Change History

comment:1 Changed 7 years ago by octo

  • Blocked By 224 added

comment:2 Changed 7 years ago by octo

  • Status changed from new to closed
  • Resolution set to fixed

Fixed through a rewrite of the IMAP parser.

Note: See TracTickets for help on using tickets.